Changes MediaUiModel to use Paintable #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Apr 3, 2024
| @@ -33,19 +33,19 @@ import com.google.android.horologist.annotations.ExperimentalHorologistApi | |||
| @Composable | |||
| @ExperimentalHorologistApi | |||
| public fun rememberArtworkColor( | |||
| artworkUri: String?, | |||
| model: Any?, | |||
There was a problem hiding this comment.
Is this a stability issue?
There was a problem hiding this comment.
Would this be better if we split into two APIs?
rememberArtworkColor(String?) and rememberArtworkColor(CoilDrawable)
yschimke
approved these changes
Apr 3, 2024
|
#2182 is going to merge conflict with this. But also I much appreciate this model, can see why it's useful. |
fstanis
force-pushed
the
paintable-in-model
branch
from
2f5b9d8 to
f72cfe6
Compare
fstanis
force-pushed
the
paintable-in-model
branch
from
f72cfe6 to
9ea46b9
Compare
LionZXY
referenced
this pull request
in flipperdevices/Flipper-Android-App
Apr 12, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) | action | digest | `b231772` -> `b5418f5` | | | | | | [org.mockito.kotlin:mockito-kotlin](https://github.com/mockito/mockito-kotlin) | dependencies | minor | `5.2.1` -> `5.3.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.google.android.horologist:horologist-compose-layout](https://github.com/google/horologist) | dependencies | patch | `0.6.6` -> `0.6.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [org.jetbrains.compose:compose-gradle-plugin](https://github.com/JetBrains/compose-jb) | dependencies | patch | `1.6.1` -> `1.6.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.android.library](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | plugin | patch | `8.3.1` -> `8.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.android.application](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | plugin | patch | `8.3.1` -> `8.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.android.tools.build:gradle](https://developer.android.com/studio/build) ([source](https://android.googlesource.com/platform/tools/base)) | dependencies | patch | `8.3.1` -> `8.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>mockito/mockito-kotlin (org.mockito.kotlin:mockito-kotlin)</summary> ### [`v5.3.1`](https://github.com/mockito/mockito-kotlin/releases/tag/5.3.1) [Compare Source](https://github.com/mockito/mockito-kotlin/compare/5.2.1...5.3.1) <sup><sup>*Changelog generated by [Shipkit Changelog Gradle Plugin](https://github.com/shipkit/shipkit-changelog)*</sup></sup> ##### 5.3.1 - 2024-04-09 - [3 commit(s)](https://github.com/mockito/mockito-kotlin/compare/5.3.0...5.3.1) by Oscar Guillén, Róbert Papp - Follow-up on [#​508](https://github.com/mockito/mockito-kotlin/issues/508): add tests and remove unnecessary methods [(#​516)](https://github.com/mockito/mockito-kotlin/pull/516) - Fix broken release ([#​509](https://github.com/mockito/mockito-kotlin/issues/509)) [(#​514)](https://github.com/mockito/mockito-kotlin/pull/514) - Add support for destructured parameters in answers [(#​512)](https://github.com/mockito/mockito-kotlin/pull/512) - Release is broken [(#​509)](https://github.com/mockito/mockito-kotlin/issues/509) - Port AdditionalMatchers matchers [(#​508)](https://github.com/mockito/mockito-kotlin/pull/508) </details> <details> <summary>google/horologist (com.google.android.horologist:horologist-compose-layout)</summary> ### [`v0.6.8`](https://github.com/google/horologist/releases/tag/v0.6.8): 0.6.8 - Media UI Improvements and updated translations ##### What's Changed - Make MediaUiModel sealed for loading and loaded data object / class by [@​laiyichin](https://github.com/laiyichin) in [https://github.com/google/horologist/pull/2179](https://github.com/google/horologist/pull/2179) - Update all dependencies by [@​renovate-bot](https://github.com/renovate-bot) in [https://github.com/google/horologist/pull/2185](https://github.com/google/horologist/pull/2185) - Update dependency com.google.ai.client.generativeai:generativeai 0.2.2 to v0.3.0 by [@​renovate-bot](https://github.com/renovate-bot) in [https://github.com/google/horologist/pull/2187](https://github.com/google/horologist/pull/2187) - Update translations by [@​fstanis](https://github.com/fstanis) in [https://github.com/google/horologist/pull/2186](https://github.com/google/horologist/pull/2186) **Full Changelog**: google/horologist@v0.6.7...v0.6.8 ### [`v0.6.7`](https://github.com/google/horologist/releases/tag/v0.6.7): 0.6.7 - Media UI improvements - Dependency updates - Screenshot testing API improvements ##### What's Changed - Update translations by [@​fstanis](https://github.com/fstanis) in [https://github.com/google/horologist/pull/2164](https://github.com/google/horologist/pull/2164) - Update all dependencies 4.26.0 to v4.26.1 by [@​renovate-bot](https://github.com/renovate-bot) in [https://github.com/google/horologist/pull/2166](https://github.com/google/horologist/pull/2166) - Update all dependencies 2.10.0 to v2.11.0 by [@​renovate-bot](https://github.com/renovate-bot) in [https://github.com/google/horologist/pull/2167](https://github.com/google/horologist/pull/2167) - Updates media display margins by [@​fstanis](https://github.com/fstanis) in [https://github.com/google/horologist/pull/2165](https://github.com/google/horologist/pull/2165) - Update all dependencies by [@​yschimke](https://github.com/yschimke) in [https://github.com/google/horologist/pull/2169](https://github.com/google/horologist/pull/2169) - Revert "Update all dependencies" by [@​yschimke](https://github.com/yschimke) in [https://github.com/google/horologist/pull/2171](https://github.com/google/horologist/pull/2171) - Updates a11y for VolumeScreen by [@​fstanis](https://github.com/fstanis) in [https://github.com/google/horologist/pull/2175](https://github.com/google/horologist/pull/2175) - Update translations by [@​fstanis](https://github.com/fstanis) in [https://github.com/google/horologist/pull/2174](https://github.com/google/horologist/pull/2174) - Update dependency com.google.devtools.ksp 1.9.23-1.0.19 to v1.9.23-1.0.20 by [@​renovate-bot](https://github.com/renovate-bot) in [https://github.com/google/horologist/pull/2178](https://github.com/google/horologist/pull/2178) - Update all dependencies by [@​yschimke](https://github.com/yschimke) in [https://github.com/google/horologist/pull/2180](https://github.com/google/horologist/pull/2180) - Migrate screenshot tests to Roborazzi by [@​yschimke](https://github.com/yschimke) in [https://github.com/google/horologist/pull/2181](https://github.com/google/horologist/pull/2181) - Cleanup a11y tests by [@​yschimke](https://github.com/yschimke) in [https://github.com/google/horologist/pull/2182](https://github.com/google/horologist/pull/2182) - Update peaceiris/actions-gh-pages action v3 to v4 by [@​renovate-bot](https://github.com/renovate-bot) in [https://github.com/google/horologist/pull/2172](https://github.com/google/horologist/pull/2172) - Changes MediaUiModel to use Paintable by [@​fstanis](https://github.com/fstanis) in [https://github.com/google/horologist/pull/2176](https://github.com/google/horologist/pull/2176) **Full Changelog**: google/horologist@v0.6.6...v0.6.7 </details> <details> <summary>JetBrains/compose-jb (org.jetbrains.compose:compose-gradle-plugin)</summary> ### [`v1.6.2`](https://github.com/JetBrains/compose-jb/blob/HEAD/CHANGELOG.md#162-April-2024) *Changes since 1.6.1* #### Features ##### Common - [Support Kotlin `2.0.0-RC1`](https://github.com/JetBrains/compose-multiplatform/pull/4596) #### Fixes ##### iOS, Desktop, Web - [Propagate composition locals to layers in the (re)composition phase](https://github.com/JetBrains/compose-multiplatform-core/pull/1233) - [Add transactions to `FocusOwnerImpl` `takeFocus` and `releaseFocus` to prevent crash when a window is re-shown](https://github.com/JetBrains/compose-multiplatform-core/pull/1231) - [Fix crash and allow selection in `SelectionContainer` to start when drag starts below the bounds of the visible text](https://github.com/JetBrains/compose-multiplatform-core/pull/1230) ##### iOS - [Fixed crash in `TextField` when a last symbol is a carriage return symbol](https://github.com/JetBrains/compose-multiplatform-core/pull/1229) #### Dependencies This version of Compose Multiplatform is based on the next Jetpack Compose libraries: - [Compiler 1.5.11](https://developer.android.com/jetpack/androidx/releases/compose-compiler#1.5.11) - [Runtime 1.6.4](https://developer.android.com/jetpack/androidx/releases/compose-runtime#1.6.4) - [UI 1.6.4](https://developer.android.com/jetpack/androidx/releases/compose-ui#1.6.4) - [Foundation 1.6.4](https://developer.android.com/jetpack/androidx/releases/compose-foundation#1.6.4) - [Material 1.6.4](https://developer.android.com/jetpack/androidx/releases/compose-material#1.6.4) - [Material3 1.2.1](https://developer.android.com/jetpack/androidx/releases/compose-material3#1.2.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/flipperdevices/Flipper-Android-App). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation as part of #1868, to reduce dependency on uris across the library.